requesting-code-review

Requesting Code Review

Run a structured review pass to catch issues before they cascade.

Core principle: Review early, review often.

When to Request Review

Mandatory:

• After each task in single-flow task execution
• After completing major feature
• Before merge to main

Optional but valuable:

• When stuck (fresh perspective)
• Before refactoring (baseline check)
• After fixing complex bug

How to Request

1. Identify the diff source:

# Option A: commit range, only if commits exist and are relevant
BASE_SHA=$(git rev-parse HEAD~1)
HEAD_SHA=$(git rev-parse HEAD)

# Option B: working tree review when there are no intermediate commits
git diff --stat
git diff

2. Run structured code review checklist:

Use requesting-code-review/code-reviewer.md template and review the diff against requirements. In single-flow mode, do not dispatch generic coding agents.

Placeholders:

• {WHAT_WAS_IMPLEMENTED} - What you just built
• {PLAN_OR_REQUIREMENTS} - What it should do
• {BASE_SHA} / {HEAD_SHA} - Starting and ending commits when reviewing a commit range
• {DIFF_SOURCE} - Description of the diff source when reviewing the working tree
• {DIFF_COMMANDS} - Exact diff commands used for the review
• {DESCRIPTION} - Brief summary

3. Act on feedback:

• Fix Critical issues immediately
• Fix Important issues before proceeding
• Note Minor issues for later
• Push back if reviewer is wrong (with reasoning)

Example

[Just completed Task 2: Add verification function]

You: Let me request code review before proceeding.

[Use working tree diff because no task commit was created]
git diff --stat
git diff

[Run checklist-based review]
  WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
  PLAN_OR_REQUIREMENTS: Task 2 from docs/plans/deployment-plan.md
  DIFF_SOURCE: current working tree
  DIFF_COMMANDS: git diff --stat && git diff
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types

[Review returns]:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

You: [Fix progress indicators]
[Continue to Task 3]

Integration with Workflows

Single-Flow Task Execution:

• Review after EACH task
• Catch issues before they compound
• Fix before moving to next task

Executing Plans:

• Review after each batch (3 tasks)
• Get feedback, apply, continue

Ad-Hoc Development:

• Review before merge
• Review when stuck

Red Flags

Never:

• Skip review because "it's simple"
• Ignore Critical issues
• Proceed with unfixed Important issues
• Argue with valid technical feedback

If reviewer wrong:

• Push back with technical reasoning
• Show code/tests that prove it works
• Request clarification

See template at: requesting-code-review/code-reviewer.md