review-quality
Formalizes the review process by verifying plan alignment, test quality, and code simplicity before finalizing implementation.
Install
mkdir -p .claude/skills/review-quality && curl -L -o skill.zip "https://agentskills.codes/api/skills/download/12208" && unzip -o skill.zip -d .claude/skills/review-quality && rm skill.zipInstalls to .claude/skills/review-quality
Activation
This is the description your AI agent reads to decide when to run this skill — the better it matches your request, the more reliably it fires.
Review quality framework for the work-to-review transition gate. Guides verification of plan alignment, test quality, and code simplification before marking implementation complete. Referenced by schema guidance fields during review-phase note filling. Use when filling review-checklist notes or when asked to review completed implementation work.Key capabilities
- →Load MCP item notes for review
- →Read changed files identified in implementation notes
- →Run and capture results of the project's test suite
- →Compare implemented work against planning notes
- →Verify test coverage against the planning note's test strategy
- →Evaluate test substance for meaningful assertions
How it works
This framework guides a reviewer to verify implementation work by loading item notes, reading changed files, running tests, and comparing the work against planning and test strategies.
Inputs & outputs
When to use review-quality
- →Review implementation against feature plans
- →Verify test coverage and quality
- →Check for unnecessary code complexity
- →Validate bug fix implementation
About this skill
Review Supplement for This Codebase
This supplements the generic review method; it never repeats it.
Build state
Read the build state the orchestrator recorded (the review scoping slot's build-state line, the
session-tracking Verified: line or the test-manifest VERIFY line) and run no Gradle suite:
rule test-author section 5 points 8 and 11. A missing build state, or one for an older SHA than
the diff under review, is a blocking finding.
Test substance (every reviewed item, with or without needs-test-author)
Fetch the served rules forbidden-test-patterns and test-assertion-vacuity as rules (config op
rules, key, rootId) and judge every test the diff adds or changes against them. Also check
for happy-path-only coverage: tests that cover only the happy path of a change that has failure and
edge cases are a gap to report.
Items with the needs-test-author trait
- Inputs: the
test-planandtest-manifestnotes, and the orchestrator's per-child SHA table (Pre-SHA, Post-SHA, Test-Pre-SHA, Test-Post-SHA) with any declared fixture-repair SHAs. A trait-bearing item with notest-plannote is a blocking issue on its own. - Declared orchestrator fixture repairs are judged by rule
test-file-ownershippoint 4 and rulereview-scopingpoint 3; they may touch only construction or setup code, never assertions. - An oracle that matches the implementation but not its cited source is blocking.
A<n>lines inorchestrator-confirmationare red-test rulings (rulearbitration).- A false forbidden-pattern declaration weighs as
not-independent. - An independence result of
independent-degraded (temporal-only)maps to Pass: record it as the observed mode, not as a finding. - Spot-check the coverage mapping: open at least two mapped tests and read their bodies rather than trusting the manifest alone.
- Check the planning freeze: when the schema declares
amendments, the planning note'smodifiedAt(notes_readlist) is its freeze time; otherwise its## Amendment A<n>sections are the only later edits. Compare the freeze with the implementer's first commit.
Items with the needs-docs-accuracy-review trait
Rule review-cited-claims point 1 governs cited lines; on a docs item it also covers claims of
defaults, limits, budgets and ordering, and wording copied from an existing doc is unverified
until its source is opened.
- Open each
claim -> source file:linepair the planner lists. - Check the Docs and CHANGELOG lines against
git diff --name-only <base>...HEAD. - Scan changed files for bytes below 0x20 other than TAB and LF, non-UTF-8 bytes and CR line endings.
Two checks the generic method lacks
- Root cause. A fix addresses the diagnosed root cause, not its symptom.
- Scenario coverage. Every scenario in the test strategy and every edge case in the diagnosis maps to a test; a missing one is a gap to report.
When not to use it
- →When the reviewer is the same agent that wrote the code or tests
- →When planning notes or implementation notes are missing
Limitations
- →The reviewer must not be the same agent that wrote the code or the tests.
- →If the planning note or implementation notes are missing, the review cannot proceed.
- →The reviewer does not advance the item.
How it compares
This skill provides a structured, independent review process to catch common failure modes, unlike an unguided review or self-assessment.
Compared to similar skills
review-quality side by side with the closest alternatives in the catalog.
| Skill | Installs | Updated | Safety | Difficulty |
|---|---|---|---|---|
| review-quality (this skill) | 0 | 4mo | No flags | Advanced |
| python-testing-patterns | 77 | 6mo | Review | Intermediate |
| dependency-upgrade | 26 | 8mo | Review | Intermediate |
| test-cases | 57 | 10mo | No flags | Beginner |
Try saying
Example prompts that trigger this skill in your AI assistant.
You might also like
python-testing-patterns
wshobson
Implement comprehensive testing strategies with pytest, fixtures, mocking, and test-driven development. Use when writing Python tests, setting up test suites, or implementing testing best practices.
dependency-upgrade
wshobson
Manage major dependency version upgrades with compatibility analysis, staged rollout, and comprehensive testing. Use when upgrading framework versions, updating major dependencies, or managing breaking changes in libraries.
test-cases
cexll
This skill should be used when generating comprehensive test cases from PRD documents or user requirements. Triggers when users request test case generation, QA planning, test scenario creation, or need structured test documentation. Produces detailed test cases covering functional, edge case, error handling, and state transition scenarios.
reviewing-code
CaptainCrouton89
Systematically evaluate code changes for security, correctness, performance, and spec alignment. Use when reviewing PRs, assessing code quality, or verifying implementation against requirements.
wcag-audit-patterns
wshobson
Conduct WCAG 2.2 accessibility audits with automated testing, manual verification, and remediation guidance. Use when auditing websites for accessibility, fixing WCAG violations, or implementing accessible design patterns.
code-coverage-with-gcov
gadievron
Add gcov code coverage instrumentation to C/C++ projects